Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-row and row span table syntax #1417

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Support multi-row and row span table syntax #1417

wants to merge 1 commit into from

Conversation

a60814billy
Copy link
Member

This PR support two new table syntax, one is multi-row syntax that use \ to merge multiple row into one row. another is row-span syntax that can merge multiple column into one colume (like html rowspan attribute)

  1. multi-row syntax example
|   Markdown   | Rendered HTML |
|--------------|---------------|
|    *Italic*  | *Italic*      | \
|              |               |
|    - Item 1  | - Item 1      | \
|    - Item 2  | - Item 2      |
|    ```python | ```python       \
|    .1 + .2   | .1 + .2         \
|    ```       | ```           |
  1. row span syntax
Stage | Direct Products | ATP Yields
----: | --------------: | ---------:
Glycolysis | 2 ATP ||
^^ | 2 NADH | 3--5 ATP |
Pyruvaye oxidation | 2 NADH | 5 ATP |
Citric acid cycle | 2 ATP ||
^^ | 6 NADH | 15 ATP |
^^ | 2 FADH2 | 3 ATP |
**30--32** ATP |||
[Net ATP yields per hexose]

@Yukaii Yukaii temporarily deployed to codimd-feature-support-sulzvre February 26, 2020 02:51 Inactive
@Yukaii
Copy link
Member

Yukaii commented Feb 26, 2020

Nice! But found that our existing table auto format would break this syntax

@a60814billy
Copy link
Member Author

a60814billy commented Feb 26, 2020 •
edited
Loading

it's a known issue, maybe we can add preference options to turn off table auto formatting.

@Yukaii Yukaii added this to the Next milestone Mar 9, 2020
@Yukaii Yukaii added the markdown label Mar 9, 2020
@jackycute jackycute removed this from the Next milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackycute jackycute Awaiting requested review from jackycute

@Yukaii Yukaii Awaiting requested review from Yukaii

Assignees

@a60814billy a60814billy

Labels
markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a60814billy @Yukaii @jackycute